gorb/frontend
4
0
Fork 0
Code Issues 6 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Polish GUI #7

Merged
justtemmie merged 10 commits from GUI-polish into main 2025-07-03 17:18:25 +00:00
Conversation 6 Commits 10 Files changed 12 +393 -102
justtemmie commented 2025-07-02 19:45:55 +00:00
Owner
Copy link

I'm working on polishing the GUI, but i need help with the layering of user popups.

It might be a better idea to have a single "global" popup, that we just change the content of and move around at runtime, opinions?

I've attached an image of the layering in question

I'm working on polishing the GUI, but i need help with the layering of user popups. It might be a better idea to have a single "global" popup, that we just change the content of and move around at runtime, opinions? I've attached an image of the layering in question
Screenshot_2025-07-02_21-29-37.png
109 KiB
Screenshot_2025-07-02_21-29-37.png
justtemmie added the
WIP
 label 2025-07-02 19:45:55 +00:00
sauceyred was assigned by justtemmie 2025-07-02 19:45:55 +00:00
justtemmie added 2 commits 2025-07-02 19:45:55 +00:00
feat: Use actual server icons instead of placeholder
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
8c92a7ad0c
feat: icons, user popus, and polish
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
692dd6d1c7 
user popus are WEIRD, and i need help with layering
justtemmie added 4 commits 2025-07-03 16:10:15 +00:00
feat: Add theming, no settings menu yet
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8033fd27e1
chore: unwanted leading tab
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
a9ad6ba535
justtemmie added 1 commit 2025-07-03 16:15:11 +00:00
feat: settings button
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
c203d26b26 
for some reason the settings menu is a bit wonky with this, but that's likely an issue with the settings menu itself interacting with nuxt being nuxt
sauceyred approved these changes 2025-07-03 16:52:35 +00:00
sauceyred left a comment
Owner
Copy link

Looks good. One of my branches has changes that will probably conflict, but I'll handle that when I get there.

As for global popup, I've been making a Modal component in the branch I'm working on for invites that should be useful.

Looks good. One of my branches has changes that will probably conflict, but I'll handle that when I get there. As for global popup, I've been making a Modal component in the branch I'm working on for invites that should be useful.
app.vue Outdated
@ -9,21 +10,20 @@
const banner = useState("banner", () => false);
let current_theme = "dark" // default theme
sauceyred commented 2025-07-03 16:43:37 +00:00
Owner
Copy link

Use pascalCase, not snake_case.

Use pascalCase, not snake_case.
components/Message.vue Outdated
@ -74,6 +77,20 @@ onMounted(async () => {
// showHover.value = !showHover.value;
//}
function getDayDifference(date_1: Date, date_2: Date) {
sauceyred commented 2025-07-03 16:45:23 +00:00
Owner
Copy link

Use pascalCase, not snake_case.

Use pascalCase, not snake_case.
justtemmie commented 2025-07-03 16:54:56 +00:00
Author
Owner
Copy link

do i merge with the silly popup thing?

do i merge with the silly popup thing?
sauceyred commented 2025-07-03 16:57:54 +00:00
Owner
Copy link

What do you mean?
Also fix the casing in the instances I commented on.

What do you mean? Also fix the casing in the instances I commented on.
justtemmie commented 2025-07-03 16:58:22 +00:00
Author
Owner
Copy link

@sauceyred wrote in #7 (comment):

What do you mean? Also fix the casing in the instances I commented on.

https://git.gorb.app/attachments/8649716a-c61b-4a4f-bd3e-7481f4390748

@sauceyred wrote in https://git.gorb.app/gorb/frontend/pulls/7#issuecomment-240: > What do you mean? Also fix the casing in the instances I commented on. https://git.gorb.app/attachments/8649716a-c61b-4a4f-bd3e-7481f4390748
sauceyred commented 2025-07-03 16:59:17 +00:00
Owner
Copy link

Nah, don't.

Nah, don't.
justtemmie added 4 commits 2025-07-03 17:04:34 +00:00
fix: lazely remove profile popups
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
2d424847f7
sauceyred approved these changes 2025-07-03 17:10:44 +00:00
sauceyred left a comment
Owner
Copy link

Good.

Good.
app.vue Outdated
@ -1,5 +1,6 @@
<template>
<div>
<link :href="'/themes/' + currentTheme + '.css'" rel="stylesheet" type="text/css"></link>
sauceyred commented 2025-07-03 17:10:14 +00:00
Owner
Copy link

Left this comment on PR #8:
Use useHead() in <script> rather than <link> in the body.

Left this comment on PR #8: Use `useHead()` in `<script>` rather than `<link>` in the body.
justtemmie added 1 commit 2025-07-03 17:17:55 +00:00
Merge branch 'main' into GUI-polish
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
edaf1aa726
justtemmie merged commit d88f5d9aea into main 2025-07-03 17:18:25 +00:00
justtemmie deleted branch GUI-polish 2025-07-03 17:18:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
sauceyred
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#7
No description provided.
Delete branch "GUI-polish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?