feat: Add theming #8

justtemmie · 2025-07-02T21:52:27Z

justtemmie commented

2025-07-02 21:52:27 +00:00

There is no settings menu for this, that will be made sometime in the future.

I just want this merged ASAP so that future commits can use variables instead of hard coded colours

is the way i modified app.vue acceptable?

There is no settings menu for this, that will be made sometime in the future. I just want this merged ASAP so that future commits can use variables instead of hard coded colours is the way i modified app.vue acceptable?

justtemmie added the

Kind/Feature

Priority

High

labels 2025-07-02 21:52:27 +00:00

sauceyred was assigned by justtemmie

2025-07-02 21:52:27 +00:00

justtemmie added 1 commit 2025-07-02 21:52:27 +00:00

feat: Add theming, no settings menu yet

ci/woodpecker/push/build-and-publish Pipeline was successful

Details

ci/woodpecker/pr/build-and-publish Pipeline was successful

Details

8033fd27e1

sauceyred approved these changes 2025-07-03 16:56:41 +00:00

sauceyred left a comment

Fix what I pointed out in the comments and it's good to go.

app.vue Outdated

					
				@ -1,5 +1,6 @@

				<template>

				  <div>

				    <link :href="'/themes/' + current_theme + '.css'" rel="stylesheet" type="text/css"></link>

sauceyred commented

2025-07-03 16:55:11 +00:00

Use useHead() in <script> rather than <link> in the body.

Use `useHead()` in `<script>` rather than `<link>` in the body.

app.vue

					
				@ -9,21 +10,20 @@

				const banner = useState("banner", () => false);

				let current_theme = "dark" // default theme

sauceyred commented

2025-07-03 16:53:56 +00:00

Use pascalCase, not snake_case.

app.vue

					
				@ -10,2 +11,4 @@

				const banner = useState("banner", () => false);

				let current_theme = "dark" // default theme

				const saved_theme = localStorage.getItem("selectedTheme");