gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

refactor how client settings are saved and loaded #32

Merged
twig merged 3 commits from client-settings-refactor into main 2025-07-12 19:59:41 +00:00
Conversation 1 Commits 3 Files changed 4 +49 -13
twig commented 2025-07-11 21:49:12 +00:00
Owner
Copy link

i decided to call the functions settingLoad and settingSave, souly so they appear next to each other within an IDE

i decided to call the functions settingLoad and settingSave, souly so they appear next to each other within an IDE
twig added 1 commit 2025-07-11 21:49:12 +00:00
refactor: load and save settings from a single object
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
5b4c278b83
twig 2025-07-11 21:49:19 +00:00
twig added 1 commit 2025-07-12 16:53:18 +00:00
fix: rename selectedThemeUrl to selectedThemeId, as they're storing IDs
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
2cc42a729b
sauceyred approved these changes 2025-07-12 19:54:45 +00:00
sauceyred left a comment
Owner
Copy link

Looks good.

Looks good.
twig added 1 commit 2025-07-12 19:58:58 +00:00
Merge remote-tracking branch 'origin/main' into client-settings-refactor
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
3e0ce16cce
twig merged commit d18f00d1c0 into main 2025-07-12 19:59:41 +00:00
twig deleted branch client-settings-refactor 2025-07-12 19:59:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#32
No description provided.
Delete branch "client-settings-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?