gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Add support for 12 and 24 hour time formats (and add radio buttons) #33

Merged
twig merged 8 commits from time-format into main 2025-07-12 20:48:36 +00:00
Conversation 2 Commits 8 Files changed 8 +167 -11
twig commented 2025-07-12 18:44:29 +00:00
Owner
Copy link

Requires #32

Requires #32
twig added 6 commits 2025-07-12 18:44:29 +00:00
refactor: load and save settings from a single object
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
5b4c278b83
feat: add radio buttons and start integrating them into time format setting
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
87a5b99e50
feat: support 12 and 24 hour formats
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
eb49450756
twig 2025-07-12 19:09:11 +00:00
  • added the
    Kind/Feature
         label
  • requested review from sauceyred
sauceyred requested changes 2025-07-12 20:25:50 +00:00
Dismissed
sauceyred left a comment
Owner
Copy link

Review comments.

Review comments.
components/Message.vue Outdated
@ -48,2 +48,3 @@
<span v-else-if="getDayDifference(date, currentDate) > 1 ">{{ date.toLocaleDateString(undefined) }},</span>
{{ date.toLocaleTimeString(undefined, { timeStyle: "short" }) }}
{{ date.toLocaleTimeString(undefined, { hour12: props.format=="12", timeStyle: "short" }) }}
sauceyred commented 2025-07-12 19:55:52 +00:00
Owner
Copy link

Add spaces around ==

Add spaces around `==`
twig marked this conversation as resolved
components/UserInterface/RadioButtons.vue Outdated
@ -0,0 +19,4 @@
}>();
// makes an array from 0 to buttonCount - 1
const incidies = Array.from({ length: props.buttonCount }, (_, i) => i)
sauceyred commented 2025-07-12 20:06:05 +00:00
Owner
Copy link

indices*
https://c.tenor.com/7pXIzb8f2rUAAAAd/tenor.gif

`indices`* https://c.tenor.com/7pXIzb8f2rUAAAAd/tenor.gif
twig marked this conversation as resolved
components/UserInterface/RadioButtons.vue
@ -0,0 +98,4 @@
border: .15em solid var(--primary-color);
}
.selected-radio-button-radio {
sauceyred commented 2025-07-12 20:25:16 +00:00
Owner
Copy link

Maybe increase contrast between circle, circle border, and background

Maybe increase contrast between circle, circle border, and background
twig commented 2025-07-12 20:44:51 +00:00
Author
Owner
Copy link

later

later
twig marked this conversation as resolved
twig added this to the Frontend MVP project 2025-07-12 20:27:14 +00:00
twig removed this from the Frontend MVP project 2025-07-12 20:27:45 +00:00
twig added 2 commits 2025-07-12 20:43:45 +00:00
fix: PR complaints
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
885fc5f906
sauceyred approved these changes 2025-07-12 20:45:56 +00:00
sauceyred left a comment
Owner
Copy link

Looks good.

Looks good.
twig added 1 commit 2025-07-12 20:48:26 +00:00
fix: move radio buttons to subfolder
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
0a8ae5fe31
twig merged commit 13d4369c48 into main 2025-07-12 20:48:36 +00:00
twig deleted branch time-format 2025-07-12 20:48:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#33
No description provided.
Delete branch "time-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?