gorb/frontend
4
0
Fork 1
Code Issues 13 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

fix: reply message ID not attached to message entity when replying, and update WebSocket interfaces #90

Merged
sauceyred merged 1 commit from fix-replying into main 2025-08-19 09:48:31 +00:00
Conversation 1 Commits 1 Files changed 2 +23 -11
sauceyred commented 2025-08-19 09:11:34 +00:00
Owner
Copy link
No description provided.
fix: reply message ID not attached to message entity when replying, and update WebSocket interfaces
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
afa9163194
requested review from Twig 2025-08-19 09:11:43 +00:00
Twig approved these changes 2025-08-19 09:14:25 +00:00
app/components/MessageArea.vue
@ -39,3 +39,3 @@
<script lang="ts" setup>
import type { MessageResponse, ScrollPosition, UserResponse, WSMessage } from '~/types/interfaces';
import type { MessageResponse, ScrollPosition, UserResponse, WSChatMessage, WSMessage } from '~/types/interfaces';
Twig commented 2025-08-19 09:13:53 +00:00
Owner
Copy link

not WSIChatMessage?

not WSIChatMessage?
sauceyred commented 2025-08-19 09:16:20 +00:00
Author
Owner
Copy link

I considered it for a few seconds (well, IWSChatMessage), but figured it'd look too clunky.

I considered it for a few seconds (well, `IWSChatMessage`), but figured it'd look too clunky.
Twig commented 2025-08-19 09:47:32 +00:00
Owner
Copy link

fair enough lmao

fair enough lmao
Twig marked this conversation as resolved
sauceyred deleted branch fix-replying 2025-08-19 09:48:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Twig
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Frontend MVP
Assignees
Clear assignees
No assignees
sauceyred
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#90
No description provided.
Delete branch "fix-replying"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?