gorb/frontend
4
0
Fork 1
Code Issues 13 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Very minor profile modal polish #79

Closed
Twig wants to merge 0 commits from profile-modal-polish into main
pull from: profile-modal-polish
merge into: gorb:main
Conversation 3 Commits - Files changed -
Twig commented 2025-08-10 23:27:38 +00:00
Owner
Copy link
No description provided.
fix: missing background on avatar
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8d625e21e4
requested review from sauceyred 2025-08-10 23:27:47 +00:00
Twig self-assigned this 2025-08-11 00:50:26 +00:00
sauceyred reviewed 2025-08-15 09:49:41 +00:00
components/Modal/ProfilePopup.vue Outdated
@ -215,3 +216,3 @@
align-self: center;
width: 100%;
width: fit-content;
sauceyred commented 2025-08-15 09:47:08 +00:00
Owner
Copy link

What's the reason for/benefit to setting the width to fit-content?

What's the reason for/benefit to setting the width to `fit-content`?
Twig commented 2025-08-15 10:12:46 +00:00
Author
Owner
Copy link

it changes the position of the scrollbar, though looking back at it 100% probably looks better tbh

it changes the position of the scrollbar, though looking back at it 100% probably looks better tbh
Twig marked this conversation as resolved
style: change about me width
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
7c350882e2
sauceyred approved these changes 2025-08-15 12:18:00 +00:00
Twig commented 2025-08-15 12:19:13 +00:00
Author
Owner
Copy link

merged manually

merged manually
Twig closed this pull request 2025-08-15 12:19:13 +00:00
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Frontend MVP
Assignees
Clear assignees
No assignees
Twig
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#79
No description provided.
Delete branch "profile-modal-polish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?