gorb/frontend
4
0
Fork 0
Code Issues 15 Pull requests 7 Projects Releases Packages 1 Wiki Activity Actions

Refactor the client to implement a channel navbar #76

Open
twig wants to merge 23 commits from navbar into main
pull from: navbar
merge into: gorb:main
Conversation 3 Commits 23 Files changed 13 +12 -18
1 changed files with 12 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 5c38f9f9fc - Show all commits

30
layouts/client.vue
View file

@ -55,7 +55,18 @@ definePageMeta({
});
const loading = useState("loading", () => false);
const navbar = useState<INavbar>("navbar")
const navbar = useState<INavbar>("navbar", () => {
return {
clientItems: [
twig marked this conversation as resolved Outdated
sauceyred commented 2025-08-10 23:47:36 +00:00
Outdated
Copy link

This should be an anchor element, not a button

This should be an anchor element, not a button
twig commented 2025-08-10 23:52:25 +00:00
Outdated
Copy link

disagree, i'd like to put an inbox here, that would be a popup, not a link

disagree, i'd like to put an inbox here, that would be a popup, not a link
sauceyred commented 2025-08-13 17:44:49 +00:00
Outdated
Copy link

Right but I think all clickable elements that lead you to an external site should be anchor elements. Here I'm specifically talking about the source code element.

Right but I think all clickable elements that lead you to an external site should be anchor elements. Here I'm specifically talking about the source code element.
twig commented 2025-08-13 17:45:27 +00:00
Outdated
Copy link

sure, i'm reworking it anyways

sure, i'm reworking it anyways
👍 1
{
title: "Source",
icon: "lucide:code-xml",
callback: () => { open("https://git.gorb.app/gorb/frontend") }
}
],
channelItems: [] // set by the channel
}
})
const createButtonContainer = ref<HTMLButtonElement>();
@ -150,23 +161,6 @@ const options = [
const guilds = await api.fetchMyGuilds();
onMounted(() => {
if (!navbar.value) {
const sourceLinkItem: NavbarItem = {
title: "Source",
icon: "lucide:code-xml",
callback: () => { open("https://git.gorb.app/gorb/frontend") }
}
navbar.value = {
clientItems: [
sourceLinkItem
],
channelItems: [] // set by the channel
}
}
})
function createDropdown() {
const dropdown = h(GuildDropdown, { options });
const div = document.createElement("div");