gorb/frontend
4
0
Fork 1
Code Issues 13 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Refactor the client to implement a channel navbar #76

Merged
Twig merged 25 commits from navbar into main 2025-08-15 12:18:24 +00:00
Conversation 5 Commits 25 Files changed 14 +519 -397
Twig commented 2025-08-08 00:09:54 +00:00
Owner
Copy link

closes #75

closes #75
Twig self-assigned this 2025-08-08 00:09:54 +00:00
feat: add "Direct Messages" state to navbar
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
89150a6cc6
requested review from sauceyred 2025-08-08 00:10:00 +00:00
refactor: move logic for default icon navbar itself
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
eb4427ff4b
fix: a crash related to accessing navbar values before setup
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
3ac8595af6
chore: change type hinting syntax on navbar init
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
74b698d728
Twig reviewed 2025-08-10 23:12:44 +00:00
layouts/client.vue Outdated
@ -68,60 +64,60 @@ const api = useApi();
const options = [
{ name: "Join", value: "join", callback: async () => {
console.log("join guild!");
Twig commented 2025-08-10 23:12:44 +00:00
Author
Owner
Copy link

what the hell did codium decide to do here? i proomise i didn't touch it

what the hell did codium decide to do here? i proomise i didn't touch it
Twig marked this conversation as resolved
chore: remove trailing new lines
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
687d491e2a
chore: remove unused navbar state reference
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
254f7c25e3
feat: move initialization of navbar state variable to the initializer parameter of its definition
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
5c38f9f9fc
sauceyred requested changes 2025-08-10 23:48:34 +00:00
Dismissed
components/UserInterface/Navbar.vue Outdated
@ -0,0 +41,4 @@
</script>
<style scoped>
#navbar {
sauceyred commented 2025-08-10 23:24:35 +00:00
Owner
Copy link

Shouldn't these variable definitions be defined in theme files?

Shouldn't these variable definitions be defined in theme files?
Twig commented 2025-08-10 23:51:38 +00:00
Author
Owner
Copy link

i suppose? they're really just there to make development easier, but they could be included in the layout theme files, if so, do we include all 4?

i suppose? they're really just there to make development easier, but they could be included in the layout theme files, if so, do we include all 4?
sauceyred commented 2025-08-13 17:45:18 +00:00
Owner
Copy link

Yeah, don't see a reason not to

Yeah, don't see a reason not to
Twig marked this conversation as resolved
layouts/client.vue Outdated
@ -62,1 +57,4 @@
const loading = useState("loading", () => false);
const navbar = useState<INavbar>("navbar", () => {
return {
clientItems: [
sauceyred commented 2025-08-10 23:47:36 +00:00
Owner
Copy link

This should be an anchor element, not a button

This should be an anchor element, not a button
Twig commented 2025-08-10 23:52:25 +00:00
Author
Owner
Copy link

disagree, i'd like to put an inbox here, that would be a popup, not a link

disagree, i'd like to put an inbox here, that would be a popup, not a link
sauceyred commented 2025-08-13 17:44:49 +00:00
Owner
Copy link

Right but I think all clickable elements that lead you to an external site should be anchor elements. Here I'm specifically talking about the source code element.

Right but I think all clickable elements that lead you to an external site should be anchor elements. Here I'm specifically talking about the source code element.
Twig commented 2025-08-13 17:45:27 +00:00
Author
Owner
Copy link

sure, i'm reworking it anyways

sure, i'm reworking it anyways
👍 1
Twig marked this conversation as resolved
Twig dismissed sauceyred's review 2025-08-13 17:38:10 +00:00
Reason:

Reworking

Twig changed title from Implement a proper navbar to wip: Implement a proper navbar 2025-08-13 17:38:18 +00:00
style: change navbar button colours on hoverr
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
c9843bf4f2
Twig changed title from wip: Implement a proper navbar to Refactor the client to implement a channel navbar 2025-08-13 19:27:42 +00:00
style: rename guildnavbar to channelnavbar
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
bb00f288f7
chore: remove unused imports
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8acf6a77eb
Twig commented 2025-08-13 19:54:21 +00:00
Author
Owner
Copy link

okay i cannot assign you to review this

i assign you to review this

okay i cannot assign you to review this i assign you to review this
Merge remote-tracking branch 'origin/main' into navbar
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
bd895c9a34
sauceyred requested changes 2025-08-15 09:39:01 +00:00
Dismissed
sauceyred left a comment
Owner
Copy link

Review comments.
Also, I'm not a big fan of the navbar going all the way to the right edge when it doesn't on the left. Maybe we should have separate guild and client navbars?

Review comments. Also, I'm not a big fan of the navbar going all the way to the right edge when it doesn't on the left. Maybe we should have separate guild and client navbars?
pages/me/[userId].vue Outdated
@ -10,1 +10,4 @@
import DirectMessagesSidebar from '~/components/Me/DirectMessagesSidebar.vue';
onMounted(async () => {
updateNavbar({isDirectMessages: true})
sauceyred commented 2025-08-15 09:20:03 +00:00
Owner
Copy link

Add spaces between curly brackets and content.
Arrow function doesn't need to be async since no await keyword is used.
updateNavbar doesn't seem to exist.

Add spaces between curly brackets and content. Arrow function doesn't need to be `async` since no `await` keyword is used. `updateNavbar` doesn't seem to exist.
Twig marked this conversation as resolved
pages/me/[userId].vue Outdated
@ -11,0 +14,4 @@
})
onActivated(async () => {
updateNavbar({isDirectMessages: true})
sauceyred commented 2025-08-15 09:20:07 +00:00
Owner
Copy link

Add spaces between curly brackets and content.
Arrow function doesn't need to be async since no await keyword is used.

Add spaces between curly brackets and content. Arrow function doesn't need to be `async` since no `await` keyword is used.
Twig marked this conversation as resolved
style: change member list and navbar colours
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
628a40f2b8
requested review from sauceyred 2025-08-15 10:29:34 +00:00
sauceyred approved these changes 2025-08-15 12:17:17 +00:00
Twig merged commit 5adae3b380 into main 2025-08-15 12:18:24 +00:00
Twig deleted branch navbar 2025-08-15 12:18:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Twig
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#76
No description provided.
Delete branch "navbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?