More improvements to context menu #69

					
				@ -0,0 +15,4 @@

				<script lang="ts" setup>

				import Button from '../UserInterface/Button.vue';

				const props = defineProps<{ actionName: string, displayName?: string, callback: CallableFunction, onClose: () => void, onCancel: () => void }>();

Twig commented

2025-08-16 10:57:27 +00:00

i don't think "displayName" is the correct term here, assuming this is a generic confirmation screen, either rename the prop to "target" or something, or rename the modal

sauceyred commented

2025-08-16 11:08:06 +00:00

Are you saying displayName isn't intuitive, or is it something else?

Are you saying `displayName` isn't intuitive, or is it something else?

Twig commented

2025-08-16 11:09:22 +00:00

well displayName seems wrong if you're talking about a server, or a role. I think of it has a member thing

sauceyred commented

2025-08-16 11:11:47 +00:00

Good point, I didn't think about that lmao

sauceyred marked this conversation as resolved

utils/createMemberContextMenuItems.ts Outdated

					
				@ -0,0 +19,4 @@

						console.log("[MENUITEM] member is not me");

						if (hasPermission(me.value, Permission.KickMember)) {

							console.log("[MENUITEM] has kick member permission");

							menuItems.splice(Math.min(3, menuItems.length), 0, {

Twig commented

2025-08-16 11:00:13 +00:00

splicing like this seems really messy, there should really be a better way of doing this

sauceyred commented

2025-08-16 11:10:49 +00:00

The purpose was mainly to make sure they would be put in the same order, but yeah I should take another look at it. I already have an idea.

sauceyred marked this conversation as resolved

sauceyred added 3 commits

2025-08-16 12:25:28 +00:00

fix: kick and ban would execute regardless of prompt due to calling the function in the Button callback prop instead of just passing it 7cb19adfbe

feat: rename Confirmation modal prop displayName to targetName c9bbd10af1

feat: replace context menu items splicing with implementation of context menu item sections

ci/woodpecker/push/build-and-publish Pipeline was successful

Details

ci/woodpecker/pr/build-and-publish Pipeline was successful

Details

0f02142eb1

requested review from Twig

2025-08-16 12:26:54 +00:00

Twig approved these changes

2025-08-16 12:26:55 +00:00

Dismissed

sauceyred commented

2025-08-16 12:27:18 +00:00

Example of when a menu has two sections:

Example of when a menu has two sections: ![image](/attachments/641d723d-dd2d-423e-b55d-80df81a6d4ed)

image.png

5 KiB

sauceyred commented

2025-08-16 12:27:52 +00:00

Did you even look through the changes??

Twig commented

2025-08-16 12:31:47 +00:00

@sauceyred wrote in #69 (comment):

Did you even look through the changes??

yeah, only took 2 minutes

@sauceyred wrote in https://git.gorb.app/gorb/frontend/pulls/69#issuecomment-1362: > Did you even look through the changes?? yeah, only took 2 minutes

sauceyred commented

2025-08-16 12:32:32 +00:00

Alrighty then

sauceyred added 7 commits

2025-08-16 13:50:21 +00:00

fix: change app.vue mousedown listener to pointerdown due to mousedown only listening to left-click, causing context menu not to be removed properly in certain cases b46533aa5f

feat: move initialization of logged-in user member state variable to channelId page 538566e9e1

feat: get context menu state variable directly in showContextMenu instead of requiring a context menu object as a parameter 1d21d476d5

fix: sidebar resizing while holding right-click 99ed210d26

feat: make custom context menu imitate browser context menu behavior 839920f124

fix: Confirmation modal target name not being displayed correctly in Message.vue due to use of display-name prop rather than target-name e28bc23d12

feat: add Confirmation modal to MemberEntry.vue