gorb/frontend
4
0
Fork 1
Code Issues 13 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Implement profile modal #52

Merged
Twig merged 27 commits from profile-modal into main 2025-08-04 19:06:45 +00:00
Conversation 2 Commits 27 Files changed 23 +459 -60
Twig commented 2025-07-19 14:55:28 +00:00
Owner
Copy link

kinda solves #50, but we probably want a smaller version as well

kinda solves #50, but we probably want a smaller version as well
Twig added 15 commits 2025-07-19 14:55:29 +00:00
feat: start adding popup
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
fe77b2c28d
Merge remote-tracking branch 'origin/main' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
36444664c2
feat: finish up the profile popup
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
b3ef59ac48
feat: finish profile popup
Some checks failed
ci/woodpecker/push/build-and-publish Pipeline failed
Details
ce306a2f72
Merge remote-tracking branch 'origin/main' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
cf84ba9d0a
fix: update sortMembers to use the new getDisplayName
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
834c9ac343
fix: remove wip name
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
3beaddf0bd
style: move profile functions into a composable
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
1ac3042470
requested review from sauceyred 2025-07-19 17:17:59 +00:00
fix: profile modal staying open even if view/route is changed
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
127f21d226
sauceyred requested changes 2025-07-21 10:30:51 +00:00
Dismissed
components/Avatar.vue Outdated
@ -33,2 +25,2 @@
} else {
displayAvatar = null
if ("username" in props.profile) {
// assume it's a UserRespone
sauceyred commented 2025-07-21 10:03:35 +00:00
Owner
Copy link

Typo

Typo
Twig commented 2025-07-21 11:16:41 +00:00
Author
Owner
Copy link

?

?
sauceyred commented 2025-07-23 19:00:20 +00:00
Owner
Copy link

You wrote “UserRespone” instead of “UserResponse” in the comment.

You wrote “UserRespone” instead of “UserResponse” in the comment.
Twig marked this conversation as resolved
components/Modal/ProfilePopup.vue Outdated
@ -0,0 +48,4 @@
<span class="date-entry-value" :title="joinDate.toLocaleTimeString()">{{ toDateString(joinDate) }}</span>
</div>
<div v-if="friendsSince" class="date-entry">
<span class="date-entry-title">Friends Since</span><br>
sauceyred commented 2025-07-21 10:24:39 +00:00
Owner
Copy link

Uncapitalize "Since"

Uncapitalize "Since"
Twig marked this conversation as resolved
fix: typos
Some checks failed
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline failed
Details
ebdb21d38f
Merge remote-tracking branch 'origin/main' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
7e387e1d52
Merge remote-tracking branch 'origin/main' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
83d4f02c3a
fix: friend icon sizes
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
7bc9858736
fix: don't duplicate the server list icons
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
cc310d61df
 
whoopsie :3
Merge remote-tracking branch 'origin/fix-canvas-images' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
24038f7767
fix: use user.uuid over user_uuid
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
5d05ec31f2
requested review from sauceyred 2025-08-04 19:03:01 +00:00
sauceyred approved these changes 2025-08-04 19:05:03 +00:00
fix: 2, use user.uuid over user_uuid
Some checks are pending
ci/woodpecker/push/build-and-publish Pipeline is pending
Details
ci/woodpecker/pr/build-and-publish Pipeline is pending
Details
9a70d89517
Merge remote-tracking branch 'origin/main' into profile-modal
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
8df646d17b
Twig merged commit f229a9176c into main 2025-08-04 19:06:45 +00:00
Twig deleted branch profile-modal 2025-08-04 19:06:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#52
No description provided.
Delete branch "profile-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?