resizable-sidebars #49

Merged

sauceyred merged 17 commits from resizable-sidebars into main 2025-07-19 06:46:26 +00:00

Conversation 5 Commits 17 Files changed 8 +224 -69

sauceyred commented 2025-07-16 21:57:12 +00:00

Owner

Copy link

Closes #46

Closes #46

sauceyred added the

Priority

Low

Kind/Feature

labels 2025-07-16 21:57:12 +00:00

sauceyred self-assigned this 2025-07-16 21:57:12 +00:00

sauceyred added 6 commits 2025-07-16 21:57:12 +00:00

feat: create resizable sidebar component f1e07bd43c

chore: rename instances of cursor to pointer in createContextMenu component and ContextMenuItem interface c295225c43

feat: remove old(?) CSS for middle-left-column in client layout eabe3b3704

style(ui): add border-right to guilds list sidebar b6970ffc1c

feat: convert channels list and members list sidebars to use resizable sidebar component 0697e60ab9

feat: update createContextMenu util to require either PointerEvent or MouseEvent and update naming of cursor to pointer 808cc980a7

requested review from Twig 2025-07-16 21:57:18 +00:00

Twig commented 2025-07-17 06:54:18 +00:00

Owner

Copy link

This looks fine, but i think the minimum width for both should be way smaller, the text should properly cut off and have a "..." at the end. And they should really be saved locally. But if you want me to do that in a separate PR, sure

This looks fine, but i think the minimum width for both should be way smaller, the text should properly cut off and have a "..." at the end. And they should really be saved locally. But if you want me to do that in a separate PR, sure

Twig approved these changes 2025-07-17 06:54:27 +00:00

Dismissed

sauceyred added 2 commits 2025-07-18 01:39:33 +00:00

feat: adjust width, min-width, and max-width of channels and members list sidebars and implement saving of widths 80df3dd13d

feat: add channel name tooltip to ChannelEntry component 4b1db5961a

sauceyred commented 2025-07-18 01:40:05 +00:00

Author

Owner

Copy link

I was gonna implement saving to localStorage but forgot lmao

I was gonna implement saving to localStorage but forgot lmao

requested review from Twig 2025-07-18 01:40:09 +00:00

sauceyred added 1 commit 2025-07-18 01:57:10 +00:00

style(ui): change width resizer's cursor from col-resize to ew-resize 315258a8d5

sauceyred added 2 commits 2025-07-18 02:09:21 +00:00

feat: add back onMounted in channelId view 317ec4bcd6

fix: that the reset context menu option reset resizable sidebar width to the localStorage value rather than the default value 118f098b46

sauceyred added 2 commits 2025-07-18 02:37:55 +00:00

chore: remove unused variables in channelId view 89d0023c07

feat: convert friends list sidebar into resizable sidebar 60e7a42f92

Twig added 1 commit 2025-07-18 05:45:05 +00:00

fix: make channel list and DM list width share storage name 49e8c34254

Twig commented 2025-07-18 05:46:08 +00:00

Owner

Copy link

i think having the channel list and DM list share width makes more sense, it's at least what i would expect it do, as a user.

i think having the channel list and DM list share width makes more sense, it's at least what i would expect it do, as a user.

Twig approved these changes 2025-07-18 05:52:58 +00:00

Twig added 2 commits 2025-07-18 06:05:32 +00:00

fix: add ellipsis overflow to DM list ad7a6b5bb6

fix: ensure avatars don't squish depending on sidebar width 3a65cfd10a

sauceyred added 1 commit 2025-07-19 06:46:15 +00:00

Merge branch 'main' into resizable-sidebars 72701c9aef

sauceyred merged commit c93a1829f8 into main 2025-07-19 06:46:26 +00:00

sauceyred deleted branch resizable-sidebars 2025-07-19 06:46:27 +00:00

sauceyred referenced this pull request from a commit 2025-07-19 06:46:28 +00:00

Merge pull request 'resizable-sidebars' (#49) from resizable-sidebars into main

Sign in to join this conversation.

Reviewers

No reviewers

Twig

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

WIP

Not yet ready

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

WIP

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

sauceyred

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#49

No description provided.