gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Implement friends list and refactor components #28

Merged
twig merged 24 commits from friends-list into main 2025-07-12 17:28:43 +00:00
Conversation 10 Commits 24 Files changed 25 +4 -2
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a3feb07e73 - Show all commits

0
components/Guild/Channel.vue → components/Guild/ChannelEntry.vue
View file

6
pages/servers/[serverId]/channels/[channelId].vue
View file

@ -18,7 +18,7 @@
</h3>
</div>
<div id="channels-list">
<Channel v-for="channel of channels" :name="channel.name"
<ChannelEntry v-for="channel of channels" :name="channel.name"
:uuid="channel.uuid" :current-uuid="(route.params.channelId as string)"
:href="`/servers/${route.params.serverId}/channels/${channel.uuid}`" />
</div>
@ -33,6 +33,7 @@
</template>
<script lang="ts" setup>
import ChannelEntry from "~/components/Guild/ChannelEntry.vue";
const route = useRoute();
@ -90,7 +91,8 @@ function handleMemberClick(member: GuildMemberResponse) {
}
#members-container {
width: 15rem;
min-width: 15rem;
max-width: 15rem;
sauceyred marked this conversation as resolved
sauceyred commented 2025-07-12 17:19:14 +00:00
Copy link

Why min-width and max-width instead of width? Is there a difference?

Why `min-width` and `max-width` instead of `width`? Is there a difference?
twig commented 2025-07-12 17:23:22 +00:00
Copy link

if we just set a width, it can expand, and it can shrink. I believe this is related to flexboxes deciding to grow in weird ways

you can see that the members list has a different width in the attachments

if we just set a width, it *can* expand, and it *can* shrink. I believe this is related to flexboxes deciding to grow in weird ways you can see that the members list has a different width in the attachments
Screenshot_2025-07-12_19-22-42.png
516 KiB
Screenshot_2025-07-12_19-22-44.png
713 KiB
Screenshot_2025-07-12_19-22-42.png Screenshot_2025-07-12_19-22-44.png
sauceyred commented 2025-07-12 17:28:04 +00:00
Copy link

Huh, weird, but okay.

Huh, weird, but okay.
border-left: 1px solid var(--padding-color);
background: var(--optional-member-list-background);
}