gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Implement friends list and refactor components #28

Merged
twig merged 24 commits from friends-list into main 2025-07-12 17:28:43 +00:00
Conversation 10 Commits 24 Files changed 25 +335 -55
twig commented 2025-07-10 23:49:47 +00:00
Owner
Copy link

this implements friends list, and friend requests.

i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there.

Closes #27

screenshot of ui attached

this implements friends list, and friend requests. i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there. Closes #27 screenshot of ui attached
Screenshot_2025-07-11_01-49-13.png
186 KiB
Screenshot_2025-07-11_01-49-13.png
twig added 12 commits 2025-07-10 23:49:47 +00:00
refactor: move the homepage to /me from /
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
a90f062181
refactor: try sorting components into sub-folders
Some checks failed
ci/woodpecker/push/build-and-publish Pipeline failed
Details
15e5a21277
feat: finish entire friends menu
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
0562127e4a
twig 2025-07-10 23:50:54 +00:00
  • added the
    Kind/Feature
         label
  • requested review from sauceyred
twig added 1 commit 2025-07-10 23:54:42 +00:00
chore: remove unnecessary code
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
4e2e61d4dc
twig added 1 commit 2025-07-10 23:56:29 +00:00
chore: "why the question mark after the username"
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
edb6c01b52 
co-authored-by: Radical <radical@radical.fun>
radical approved these changes 2025-07-11 22:00:36 +00:00
sauceyred commented 2025-07-12 16:40:35 +00:00
Owner
Copy link

Is there a reason for using links instead of the Button component?

Is there a reason for using links instead of the Button component?
twig commented 2025-07-12 16:49:08 +00:00
Author
Owner
Copy link

@sauceyred wrote in #28 (comment):

Is there a reason for using links instead of the Button component?

there was originally, but now that you mention it, not really, i'll go change that

@sauceyred wrote in https://git.gorb.app/gorb/frontend/pulls/28#issuecomment-457: > Is there a reason for using links instead of the Button component? there was originally, but now that you mention it, not really, i'll go change that
sauceyred commented 2025-07-12 16:49:59 +00:00
Owner
Copy link

I've already made some changes, mind if I push so you can review?

I've already made some changes, mind if I push so you can review?
twig commented 2025-07-12 16:50:17 +00:00
Author
Owner
Copy link

go ahead

go ahead
sauceyred added 3 commits 2025-07-12 16:58:39 +00:00
feat: use <style module> for friends list-scoped css
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
890fbebbe9
twig added 3 commits 2025-07-12 17:14:37 +00:00
feat: add friend count to buttons on friend page
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
b731228fb8
sauceyred approved these changes 2025-07-12 17:20:31 +00:00
Dismissed
sauceyred left a comment
Owner
Copy link

Review comments

Review comments
composables/api.ts Outdated
@ -35,0 +38,4 @@
}
async function addFriend(username: string): Promise<void> {
await fetchWithApi('/me/friends', { method: "POST", body: { username } });
sauceyred commented 2025-07-12 17:17:44 +00:00
Owner
Copy link

Add return for consistency

Add `return` for consistency
twig marked this conversation as resolved
composables/api.ts Outdated
@ -35,0 +42,4 @@
}
async function removeFriend(userId: string): Promise<void> {
await fetchWithApi(`/me/friends/${userId}`, { method: "DELETE" });
sauceyred commented 2025-07-12 17:17:48 +00:00
Owner
Copy link

Add return for consistency

Add `return` for consistency
twig marked this conversation as resolved
pages/servers/[serverId]/channels/[channelId].vue
@ -93,2 +93,3 @@
#members-container {
width: 15rem;
min-width: 15rem;
max-width: 15rem;
sauceyred commented 2025-07-12 17:19:14 +00:00
Owner
Copy link

Why min-width and max-width instead of width? Is there a difference?

Why `min-width` and `max-width` instead of `width`? Is there a difference?
twig commented 2025-07-12 17:23:22 +00:00
Author
Owner
Copy link

if we just set a width, it can expand, and it can shrink. I believe this is related to flexboxes deciding to grow in weird ways

you can see that the members list has a different width in the attachments

if we just set a width, it *can* expand, and it *can* shrink. I believe this is related to flexboxes deciding to grow in weird ways you can see that the members list has a different width in the attachments
Screenshot_2025-07-12_19-22-42.png
516 KiB
Screenshot_2025-07-12_19-22-44.png
713 KiB
Screenshot_2025-07-12_19-22-42.png Screenshot_2025-07-12_19-22-44.png
sauceyred commented 2025-07-12 17:28:04 +00:00
Owner
Copy link

Huh, weird, but okay.

Huh, weird, but okay.
sauceyred marked this conversation as resolved
pages/settings.vue Outdated
@ -18,3 +18,3 @@
{{ page.displayName }}
</li>
<span class="spacer"></span>
<verticalSpacer />
sauceyred commented 2025-07-12 17:19:32 +00:00
Owner
Copy link

Incorrect capitalization

Incorrect capitalization
twig marked this conversation as resolved
pages/settings.vue Outdated
@ -24,3 +24,3 @@
<Button text="Log Out" :callback=logout variant="scary"></Button>
</p>
<span class="spacer"></span>
<verticalSpacer />
sauceyred commented 2025-07-12 17:19:36 +00:00
Owner
Copy link

Incorrect capitalization

Incorrect capitalization
twig marked this conversation as resolved
requested review from sauceyred 2025-07-12 17:20:39 +00:00
twig added 2 commits 2025-07-12 17:24:54 +00:00
fix: VerticalSpacer being referred to as verticalSpacer
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
3fc8933b1e
twig commented 2025-07-12 17:26:11 +00:00
Author
Owner
Copy link

👍

👍
sauceyred commented 2025-07-12 17:26:12 +00:00
Owner
Copy link

i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there.

I think it auto-imports top-level components, but components in subdirectories require manual import.

> i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there. I think it auto-imports top-level components, but components in subdirectories require manual import.
sauceyred approved these changes 2025-07-12 17:27:02 +00:00
sauceyred left a comment
Owner
Copy link

Looks good.

Looks good.
twig commented 2025-07-12 17:27:11 +00:00
Author
Owner
Copy link

@sauceyred wrote in #28 (comment):

i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there.

I think it auto-imports top-level components, but components in subdirectories require manual import.

yeah, that's what i experienced, was just wondering if there was a way around it

@sauceyred wrote in https://git.gorb.app/gorb/frontend/pulls/28#issuecomment-475: > > i also sorted the components into sub-folders, but this now sadly requires us to import them, sometimes. I have no idea what the behavior is, but i can't stand a folder of 25 files just laying there. > > I think it auto-imports top-level components, but components in subdirectories require manual import. yeah, that's what i experienced, was just wondering if there was a way around it
twig added 1 commit 2025-07-12 17:27:27 +00:00
Merge branch 'main' into friends-list
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
457405186a
twig added 1 commit 2025-07-12 17:28:34 +00:00
fix: add friends by username, not ID
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
b0e56e1a06
twig merged commit 1d1cfa0af2 into main 2025-07-12 17:28:43 +00:00
twig deleted branch friends-list 2025-07-12 17:28:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
radical
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#28
No description provided.
Delete branch "friends-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?