Seperate themes and layouts into seperate settings #63

Merged
twig merged 13 commits from better-themes into main 2025-08-05 21:47:20 +00:00
Owner

also added 5 new colour css variables, also added IRC colours for member list

closes #30

also added 5 new colour css variables, also added IRC colours for member list closes #30
twig added the
Kind/Enhancement
Priority
Low
labels 2025-08-05 02:21:03 +00:00
twig added 9 commits 2025-08-05 02:21:04 +00:00
feat: implement layout switching and saving
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
37ebcb74aa
implement layout previews
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
d5b2b43bf5
feat: default to light mode if the browser prefers light mode
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
3866ced880
feat: add more colours to dark theme
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
cb61754c0a
feat:? add IRC colours to every user and member entry
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
ci/woodpecker/pr/build-and-publish Pipeline was successful
26e215ed23
requested review from sauceyred 2025-08-05 02:23:04 +00:00
sauceyred reviewed 2025-08-05 21:31:44 +00:00
sauceyred left a comment
Owner

Merge main into this after making these changes, so I can check that it works properly.

Merge main into this after making these changes, so I can check that it works properly.
@ -41,3 +66,3 @@
const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"]
const themes: Array<Theme> = []
enum StyleLayout {
Owner

Enum options should use PascalCase

Enum options should use PascalCase
twig marked this conversation as resolved
@ -63,1 +89,3 @@
themes.push(themeConfig)
const metadataMatch = styleData.match(/\/\*([\s\S]*?)\*\//);
if (!metadataMatch) {
alert(`Failed to fetch metadata for a theme, panicing`)
Owner

Should be "panicking"

Should be "panicking"
twig marked this conversation as resolved
@ -64,0 +101,4 @@
let previewImageUrl: string | undefined
for (const line of commentContent) {
const line_array = line.split("=")
Owner

lineArray please

`lineArray` please
twig marked this conversation as resolved
@ -67,1 +138,3 @@
await fetchThemes()
async function parseThemeLayout(
folder: string,
incomingThemeList: Array<string>,
Owner

string[] instead of Array<string>

`string[]` instead of `Array<string>`
twig marked this conversation as resolved
@ -68,0 +138,4 @@
async function parseThemeLayout(
folder: string,
incomingThemeList: Array<string>,
outputThemeList: Array<Theme>) {
Owner

string[] instead of Array<string>

`string[]` instead of `Array<string>`
twig marked this conversation as resolved
@ -68,0 +148,4 @@
}
}
const styles: Array<Theme> = [];
Owner

string[] instead of Array<string>

`string[]` instead of `Array<string>`
twig marked this conversation as resolved
@ -68,0 +149,4 @@
}
const styles: Array<Theme> = [];
const layouts: Array<Theme> = [];
Owner

Theme[] instead of Array<Theme>

`Theme[]` instead of `Array<Theme>`
twig marked this conversation as resolved
@ -68,0 +151,4 @@
const styles: Array<Theme> = [];
const layouts: Array<Theme> = [];
const styleList: any = await $fetch(`${styleFolder}/styles.json`)
Owner

Avoid use of any

Avoid use of `any`
twig marked this conversation as resolved
@ -68,0 +152,4 @@
const layouts: Array<Theme> = [];
const styleList: any = await $fetch(`${styleFolder}/styles.json`)
const layoutList: any = await $fetch(`${layoutFolder}/layouts.json`)
Owner

Avoid use of any

Avoid use of `any`
twig marked this conversation as resolved
twig referenced this pull request from a commit 2025-08-05 21:39:04 +00:00
twig added 3 commits 2025-08-05 21:39:04 +00:00
Merge remote-tracking branch 'origin/main' into better-themes
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
ci/woodpecker/pr/build-and-publish Pipeline was successful
8178a1db6b
sauceyred requested changes 2025-08-05 21:44:31 +00:00
Dismissed
@ -41,3 +66,3 @@
const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"]
const themes: Array<Theme> = []
enum styleLayout {
Owner

Both enum and enum options should use PascalCase/CamelCase, that's what I meant.

enum StyleLayout  {
  Style,
  Layout
}
Both _enum_ and enum _options_ should use PascalCase/CamelCase, that's what I meant. ```ts enum StyleLayout { Style, Layout } ```
Author
Owner

okay this makes more sense

okay this makes more sense
twig marked this conversation as resolved
twig added 1 commit 2025-08-05 21:46:23 +00:00
style: use PascalCase for enums
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
ci/woodpecker/pr/build-and-publish Pipeline was successful
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
184be67ccc
sauceyred approved these changes 2025-08-05 21:47:07 +00:00
twig merged commit 6df0545f41 into main 2025-08-05 21:47:20 +00:00
twig deleted branch better-themes 2025-08-05 21:47:20 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#63
No description provided.