Seperate themes and layouts into seperate settings #63
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: gorb/frontend#63
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "better-themes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
also added 5 new colour css variables, also added IRC colours for member list
closes #30
Merge main into this after making these changes, so I can check that it works properly.
@ -41,3 +66,3 @@
const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"]
const themes: Array<Theme> = []
enum StyleLayout {
Enum options should use PascalCase
@ -63,1 +89,3 @@
themes.push(themeConfig)
const metadataMatch = styleData.match(/\/\*([\s\S]*?)\*\//);
if (!metadataMatch) {
alert(`Failed to fetch metadata for a theme, panicing`)
Should be "panicking"
@ -64,0 +101,4 @@
let previewImageUrl: string | undefined
for (const line of commentContent) {
const line_array = line.split("=")
lineArray
please@ -67,1 +138,3 @@
await fetchThemes()
async function parseThemeLayout(
folder: string,
incomingThemeList: Array<string>,
string[]
instead ofArray<string>
@ -68,0 +138,4 @@
async function parseThemeLayout(
folder: string,
incomingThemeList: Array<string>,
outputThemeList: Array<Theme>) {
string[]
instead ofArray<string>
@ -68,0 +148,4 @@
}
}
const styles: Array<Theme> = [];
string[]
instead ofArray<string>
@ -68,0 +149,4 @@
}
const styles: Array<Theme> = [];
const layouts: Array<Theme> = [];
Theme[]
instead ofArray<Theme>
@ -68,0 +151,4 @@
const styles: Array<Theme> = [];
const layouts: Array<Theme> = [];
const styleList: any = await $fetch(`${styleFolder}/styles.json`)
Avoid use of
any
@ -68,0 +152,4 @@
const layouts: Array<Theme> = [];
const styleList: any = await $fetch(`${styleFolder}/styles.json`)
const layoutList: any = await $fetch(`${layoutFolder}/layouts.json`)
Avoid use of
any
@ -41,3 +66,3 @@
const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"]
const themes: Array<Theme> = []
enum styleLayout {
Both enum and enum options should use PascalCase/CamelCase, that's what I meant.
okay this makes more sense