gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Sort members list #45

Merged
twig merged 11 commits from sort-members-list into main 2025-07-18 05:34:44 +00:00
Conversation 2 Commits 11 Files changed 20 +231 -34
twig commented 2025-07-16 08:51:06 +00:00
Owner
Copy link

requires #44

also cleans up the api a bit, just like #44

requires #44 also cleans up the api a bit, just like #44
twig added the
Kind/Enhancement
 label 2025-07-16 08:51:06 +00:00
twig added 9 commits 2025-07-16 08:51:07 +00:00
chore: update rest of the codebase to use new getDisplayName() function
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ab87fb681c
fix: accidentally getting display name of wrong user in replies
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ce5d65e62d
feat: sort member's list alphabetically
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
4229682d69
requested review from sauceyred 2025-07-16 08:51:11 +00:00
twig added 1 commit 2025-07-16 08:59:18 +00:00
style: seperate out sortUsers and sortMembers
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
f6ede67c26
sauceyred requested changes 2025-07-16 09:23:32 +00:00
Dismissed
utils/sortMembers.ts Outdated
@ -0,0 +1,7 @@
import type { GuildMemberResponse } from "~/types/interfaces";
export default function sortMembers(members: GuildMemberResponse[]): GuildMemberResponse[] {
sauceyred commented 2025-07-16 09:22:42 +00:00
Owner
Copy link

No need to name function here, name is derived from file name

No need to name function here, name is derived from file name
twig marked this conversation as resolved
utils/sortUsers.ts Outdated
@ -0,0 +1,7 @@
import type { UserResponse } from "~/types/interfaces";
export default function sortUsers(users: UserResponse[]): UserResponse[] {
sauceyred commented 2025-07-16 09:22:57 +00:00
Owner
Copy link

No need to name function here, name is derived from file name

No need to name function here, name is derived from file name
twig marked this conversation as resolved
twig added 3 commits 2025-07-16 09:29:13 +00:00
fix: allow optional argument instead of defaulting to undefined
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
d5b7669291
style: remove function names from implicit util functions
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
0c4d42f3c1
requested review from sauceyred 2025-07-16 09:39:54 +00:00
sauceyred added the
Reviewed
Confirmed
Priority
Low
 labels 2025-07-18 01:43:13 +00:00
sauceyred added 2 commits 2025-07-18 01:49:37 +00:00
feat: rename validation util file to validateUsername
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8ffe3aa738
sauceyred approved these changes 2025-07-18 01:50:27 +00:00
twig added 1 commit 2025-07-18 05:34:26 +00:00
Merge remote-tracking branch 'origin/main' into sort-members-list
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
771c0699a7
twig merged commit 232aec13a5 into main 2025-07-18 05:34:44 +00:00
twig deleted branch sort-members-list 2025-07-18 05:34:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#45
No description provided.
Delete branch "sort-members-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?