gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Move /me/friends to /me, as the new landing page #44

Merged
twig merged 5 commits from update-friend-landing-page into main 2025-07-16 09:42:39 +00:00
Conversation 2 Commits 5 Files changed 14 +72 -75
twig commented 2025-07-16 08:34:08 +00:00
Owner
Copy link

also implemented getDisplayName(user, member?) to help sort the friend list.

Also also fetchFriends() in api.ts to always return Promise<UserResponse[]>, instead of Promise<UserResponse[] | undefined>

also implemented getDisplayName(user, member?) to help sort the friend list. Also also fetchFriends() in api.ts to always return Promise<UserResponse[]>, instead of Promise<UserResponse[] | undefined>
twig added the
Kind/Enhancement
 label 2025-07-16 08:34:08 +00:00
twig added 4 commits 2025-07-16 08:34:09 +00:00
chore: update rest of the codebase to use new getDisplayName() function
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ab87fb681c
fix: accidentally getting display name of wrong user in replies
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ce5d65e62d
requested review from sauceyred 2025-07-16 08:34:13 +00:00
sauceyred requested changes 2025-07-16 09:18:17 +00:00
Dismissed
components/Me/FriendsList.vue
@ -27,3 +27,3 @@
const { fetchFriends } = useApi();
const friends = await fetchFriends()
const friends = await fetchFriends().then((response) => {
sauceyred commented 2025-07-16 09:14:49 +00:00
Owner
Copy link

Do sorting in new-line (friends.sort()) rather than with .then().

Do sorting in new-line (`friends.sort()`) rather than with `.then()`.
twig commented 2025-07-16 09:28:26 +00:00
Author
Owner
Copy link

fixed in #45

fixed in #45
twig marked this conversation as resolved
utils/getDisplayName.ts Outdated
@ -0,0 +1,7 @@
import type { GuildMemberResponse, UserResponse } from "~/types/interfaces";
export function getDisplayName(user: UserResponse, member: GuildMemberResponse | undefined = undefined): string {
sauceyred commented 2025-07-16 09:17:58 +00:00
Owner
Copy link

Make member optional instead of defaulting to undefined

Make `member` optional instead of defaulting to `undefined`
twig marked this conversation as resolved
twig added 1 commit 2025-07-16 09:28:14 +00:00
fix: allow optional argument instead of defaulting to undefined
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
d5b7669291
requested review from sauceyred 2025-07-16 09:39:52 +00:00
sauceyred approved these changes 2025-07-16 09:42:09 +00:00
twig merged commit f26c5fd7ce into main 2025-07-16 09:42:39 +00:00
twig deleted branch update-friend-landing-page 2025-07-16 09:42:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#44
No description provided.
Delete branch "update-friend-landing-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?