WIP: Audit Logs #45
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: gorb/backend#45
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "wip/auditlog"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some thoughts
@ -55,7 +51,9 @@ pub async fn delete(
.check_permission(&mut conn, &app_state.cache_pool, Permissions::ManageChannel)
.await?;
let log_entrie = AuditLog::new(channel.guild_uuid, AuditLogId::ChannelDelete as i16, member.uuid, None, None, None, None, Some(channel.name.clone()), None, None).await;
log_entry
*There are several instances of this typo
But if I want to type it with an ie
@ -47,2 +48,4 @@
.route("/bans", get(bans::get))
.route("/bans/{uuid}", delete(bans::unban))
// Audit Logs
.route("/auditlogs", get(auditlogs::get))
I think we should use either
audit-logs
or justlogs
as the endpointWhy?
@ -0,0 +11,4 @@
use serde::{Deserialize, Serialize};
use uuid::Uuid;
pub enum AuditLogId {
If we're gonna use
OBJECT_ACTION
format (e.g.MEMBER_BAN
) for the WebSocket events, should we use it for audit logs as well instead of using integers?View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.