gorb/backend
5
0
Fork 0
Code Issues 16 Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

wip/member-improvements #44

Closed
radical wants to merge 0 commits from wip/member-improvements into main
pull from: wip/member-improvements
merge into: gorb:main
Conversation 3 Commits - Files changed -
radical commented 2025-08-04 20:58:39 +00:00
Owner
Copy link

Renames function Member::fetch_one_with_member() to Member::fetch_one_with_uuid()

Changes how member fetching is done to fetch member, user and friend status in the same sql request, makes requests miles faster.

Add pagination to members
Example pagination without objects filled

{
  "objects": [],
  "amount": 50,
  "pages": 100,
  "page": 10
}

Requests with pagination will have 2 query parameters, page and per_page

Renames function Member::fetch_one_with_member() to Member::fetch_one_with_uuid() Changes how member fetching is done to fetch member, user and friend status in the same sql request, makes requests miles faster. Add pagination to members Example pagination without objects filled ```json { "objects": [], "amount": 50, "pages": 100, "page": 10 } ``` Requests with pagination will have 2 query parameters, page and per_page
radical added 2 commits 2025-08-04 20:58:39 +00:00
refactor: rename fetch_one_with_member
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8d91ec78a6 
Renamed to fetch_one_with_uuid
baaboe approved these changes 2025-08-04 21:41:39 +00:00
Dismissed
src/objects/member.rs
@ -130,0 +169,4 @@
)
.order_by(coalesce(
dsl::nickname,
users::display_name,
baaboe commented 2025-08-04 21:34:57 +00:00
Member
Copy link

Why is it ordering a single member

Why is it ordering a single member
baaboe marked this conversation as resolved
src/objects/member.rs
@ -146,0 +209,4 @@
.order_by(coalesce(
dsl::nickname,
users::display_name,
users::username,
baaboe commented 2025-08-04 21:37:21 +00:00
Member
Copy link

Why ordering a single member

Why ordering a single member
baaboe marked this conversation as resolved
src/objects/member.rs Outdated
@ -146,0 +226,4 @@
dsl::nickname,
users::display_name,
users::username,
))
baaboe commented 2025-08-04 21:37:42 +00:00
Member
Copy link

Why ordering a single member

Why ordering a single member
src/objects/mod.rs
@ -79,0 +79,4 @@
#[derive(Serialize)]
pub struct Pagination<T> {
objects: Vec<T>,
amount: i32,
baaboe commented 2025-08-04 21:40:23 +00:00
Member
Copy link

More consistency on variable names. amount and per_page should have same name.

More consistency on variable names. amount and per_page should have same name.
radical added 2 commits 2025-08-04 22:02:37 +00:00
fix: use dedicated function for member count
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
ac1678bfa8
baaboe approved these changes 2025-08-04 22:05:06 +00:00
radical commented 2025-08-04 22:09:41 +00:00
Author
Owner
Copy link

Merged manually

Merged manually
radical closed this pull request 2025-08-04 22:09:41 +00:00
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
baaboe
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/backend#44
No description provided.
Delete branch "wip/member-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?