gorb/backend
5
0
Fork 0
Code Issues 18 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Added ban/unban endpoint #37

Closed
baaboe wants to merge 0 commits from wip/ban into main
pull from: wip/ban
merge into: gorb:main
Conversation 6 Commits - Files changed -
baaboe commented 2025-07-22 22:53:29 +00:00
Member
Copy link
No description provided.
style: cargo clippy --fix && cargo fmt
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8e31dc7aca
fix: Updated error message when banning owner
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
6999b4120e
Twig commented 2025-07-22 23:10:19 +00:00
Owner
Copy link

this doesn't check the user's roles

i'm unsure how far along we are on the roles train, but i know they exist, ask radial

this doesn't check the user's roles i'm unsure how far along we are on the roles train, but i know they *exist*, ask radial
Twig 2025-07-22 23:10:26 +00:00
  • added the
    Kind/Feature
         label
  • requested review from radical
fix: baner :)
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
2bc702f8d2
baaboe commented 2025-07-22 23:20:03 +00:00
Author
Member
Copy link

@twig wrote in #37 (comment):

this doesn't check the user's roles

i'm unsure how far along we are on the roles train, but i know they exist, ask radial

But it does

@twig wrote in https://git.gorb.app/gorb/backend/pulls/37#issuecomment-850: > this doesn't check the user's roles > > i'm unsure how far along we are on the roles train, but i know they _exist_, ask radial But it does
baaboe self-assigned this 2025-07-22 23:20:22 +00:00
feat: ban permission
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
5fe5186142
fix: plural fix thing
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ceaa37cbe2
feat: idiot(goin) proofing
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
cbdf6f79e2
style: formatting
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
bb8927840d
style: cargo clippy --fix && cargo fmt
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
26f528819e
baaboe changed title from Added ban endpoint to WIP: Added ban endpoint 2025-07-23 17:13:33 +00:00
radical reviewed 2025-07-23 21:00:13 +00:00
migrations/2025-07-22-195121_add_ban/up.sql Outdated
@ -0,0 +3,4 @@
guild_uuid uuid NOT NULL REFERENCES guilds(uuid) ON DELETE CASCADE,
user_uuid uuid NOT NULL REFERENCES users(uuid),
reason VARCHAR(200) DEFAULT NULL,
ban_time TIMESTAMPTZ NOT NULL DEFAULT NOW(),
radical commented 2025-07-23 21:00:13 +00:00
Owner
Copy link

can you change ban_time to be called banned_since instead maybe?

can you change `ban_time` to be called `banned_since` instead maybe?
baaboe marked this conversation as resolved
style: renaming parameter, ban_time -> banned_since
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
c2b5f6568f
feat: added unband endpoint
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
0e0c590e4d
baaboe changed title from WIP: Added ban endpoint to Added ban endpoint 2025-07-24 00:15:21 +00:00
baaboe changed title from Added ban endpoint to Added ban/unban endpoint 2025-07-24 00:15:40 +00:00
radical requested changes 2025-07-24 21:49:54 +00:00
Dismissed
src/objects/member.rs
@ -171,1 +170,4 @@
let banned = GuildBan::fetch_one(&mut conn, guild_uuid, user_uuid).await;
match banned {
Ok(_) => Err(Error::Forbidden("User banned".to_string())),
radical commented 2025-07-24 21:48:13 +00:00
Owner
Copy link

This should return a 400 (bad request) on an already banned user, its a bad request as its not forbidden for the user to do it, its just not a possibility for someone to be banned twice

This should return a 400 (bad request) on an already banned user, its a bad request as its not forbidden for the user to do it, its just not a possibility for someone to be banned twice
baaboe marked this conversation as resolved
src/objects/member.rs Outdated
@ -189,3 +195,3 @@
pub async fn delete(self, conn: &mut Conn) -> Result<(), Error> {
delete(guild_members::table)
diesel::delete(guild_members::table)
radical commented 2025-07-24 21:49:07 +00:00
Owner
Copy link

please just import the delete statement instead of doing diesel::delete here so we have consistency in the codebase

please just import the delete statement instead of doing `diesel::delete` here so we have consistency in the codebase
baaboe marked this conversation as resolved
style: cargo clippy --fix && cargo fmt
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
4a2f98a180
radical approved these changes 2025-07-24 22:28:36 +00:00
radical commented 2025-07-24 22:40:54 +00:00
Owner
Copy link

merged manually

merged manually
radical closed this pull request 2025-07-24 22:40:54 +00:00
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
radical
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
baaboe
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/backend#37
No description provided.
Delete branch "wip/ban"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?