gorb/frontend
4
0
Fork 0
Code Issues 15 Pull requests 7 Projects Releases Packages 1 Wiki Activity Actions

Seperate themes and layouts into seperate settings #63

Merged
twig merged 13 commits from better-themes into main 2025-08-05 21:47:20 +00:00
Conversation 3 Commits 13 Files changed 27 +7 -7
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 184be67ccc - Show all commits

14
components/Settings/AppSettings/Appearance.vue
View file

@ -9,7 +9,7 @@
<div v-for="style of styles" class="theme-preview-container"> <div v-for="style of styles" class="theme-preview-container">
<span class="theme-instance" <span class="theme-instance"
:title="style.displayName" :title="style.displayName"
@click="changeTheme(styleLayout.style, style)"> @click="changeTheme(StyleLayout.Style, style)">
<div class="theme-content-container"> <div class="theme-content-container">
<span class="style-background" <span class="style-background"
:style="{background:`linear-gradient(${style.previewGradient})`}" :style="{background:`linear-gradient(${style.previewGradient})`}"
@ -26,7 +26,7 @@
<div v-for="layout of layouts" class="theme-preview-container"> <div v-for="layout of layouts" class="theme-preview-container">
<div class="theme-instance" <div class="theme-instance"
:title="layout.displayName" :title="layout.displayName"
@click="changeTheme(styleLayout.layout, layout)"> @click="changeTheme(StyleLayout.Layout, layout)">
<div class="theme-content-container"> <div class="theme-content-container">
<span class="layout-background" <span class="layout-background"
:style="{backgroundImage:`url(${layout.previewImageUrl})`}" :style="{backgroundImage:`url(${layout.previewImageUrl})`}"
@ -65,9 +65,9 @@ const layoutFolder = `${baseURL}themes/layout`
const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"] const timeFormatTextStrings = ["Auto", "12-Hour", "24-Hour"]
enum styleLayout { enum StyleLayout {
twig marked this conversation as resolved Outdated
sauceyred commented 2025-08-05 21:20:51 +00:00
Outdated
Copy link

Enum options should use PascalCase

Enum options should use PascalCase
twig marked this conversation as resolved Outdated
sauceyred commented 2025-08-05 21:43:32 +00:00
Outdated
Copy link

Both enum and enum options should use PascalCase/CamelCase, that's what I meant.

enum StyleLayout  {
  Style,
  Layout
}
Both _enum_ and enum _options_ should use PascalCase/CamelCase, that's what I meant. ```ts enum StyleLayout { Style, Layout } ```
twig commented 2025-08-05 21:45:36 +00:00
Outdated
Copy link

okay this makes more sense

okay this makes more sense
style, Style,
layout Layout
} }
interface Theme { interface Theme {
@ -161,8 +161,8 @@ if (Array.isArray(layoutList)) {
await parseThemeLayout(layoutFolder, layoutList, layouts) await parseThemeLayout(layoutFolder, layoutList, layouts)
} }
function changeTheme(themeType: styleLayout, theme: Theme) { function changeTheme(themeType: StyleLayout, theme: Theme) {
if (themeType == styleLayout.style) { if (themeType == StyleLayout.Style) {
settingSave("selectedThemeStyle", theme.themeUrl) settingSave("selectedThemeStyle", theme.themeUrl)
} else { } else {
settingSave("selectedThemeLayout", theme.themeUrl) settingSave("selectedThemeLayout", theme.themeUrl)