gorb/frontend
4
0
Fork 0
Code Issues 14 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Polish the modals #80

Merged
temmie merged 6 commits from modal-polish into main 2025-08-15 12:20:45 +00:00
Conversation 2 Commits 6 Files changed 9 +37 -67
temmie commented 2025-08-11 00:48:17 +00:00
Owner
Copy link

now they're closed by just clicking outside of them!

breaks invite modal, doesn't properly interact with embed modal, both should be modal components either way

closes #71

now they're closed by just clicking outside of them! breaks invite modal, doesn't properly interact with embed modal, both should be modal components either way closes #71
temmie added the
Kind/Enhancement
Priority
Medium
 labels 2025-08-11 00:48:17 +00:00
temmie self-assigned this 2025-08-11 00:48:17 +00:00
temmie added 4 commits 2025-08-11 00:48:18 +00:00
feat: add embed radius
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
002b6982a6
requested review from sauceyred 2025-08-11 00:48:21 +00:00
sauceyred requested changes 2025-08-15 09:57:58 +00:00
Dismissed
components/Modal/Base.vue
@ -57,2 +39,3 @@
max-width: 90dvw;
overflow: hidden;
background-color: var(--modal-background-color);
sauceyred commented 2025-08-15 09:56:39 +00:00
Owner
Copy link

background-color is set again at the bottom, so this should be removed

`background-color` is set again at the bottom, so this should be removed
temmie marked this conversation as resolved
temmie added 1 commit 2025-08-15 10:14:25 +00:00
chore: remove duplicate style line
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
1332cb5a88
requested review from sauceyred 2025-08-15 10:29:38 +00:00
sauceyred approved these changes 2025-08-15 12:18:31 +00:00
temmie added 1 commit 2025-08-15 12:20:41 +00:00
Merge remote-tracking branch 'origin/main' into modal-polish
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
315867fff5
temmie merged commit 9dd6d73d5d into main 2025-08-15 12:20:45 +00:00
temmie deleted branch modal-polish 2025-08-15 12:20:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
temmie
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#80
No description provided.
Delete branch "modal-polish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?