gorb/frontend
4
0
Fork 0
Code Issues 7 Pull requests 3 Projects Releases Packages 1 Wiki Activity Actions

Require refetching the theme whenever a new version releases #43

Merged
twig merged 4 commits from force-css-regrab into main 2025-07-18 05:32:12 +00:00
Conversation 3 Commits 4 Files changed 3 +38 -27
twig commented 2025-07-16 03:34:50 +00:00
Owner
Copy link

we have a problem that when we push a new version of the frontend that add new theme parameters, they may be cached by the user. This can cause weird behaviour, such as the guild list taking up half the width of the screen, since the new theme data isn't available.

Requesting review to know if you have a better solution

we have a problem that when we push a new version of the frontend that add new theme parameters, they may be cached by the user. This can cause weird behaviour, such as the guild list taking up half the width of the screen, since the new theme data isn't available. Requesting review to know if you have a better solution
twig added the
Kind/Feature
 label 2025-07-16 03:34:50 +00:00
twig added 1 commit 2025-07-16 03:34:50 +00:00
feat: refactor code to require refetching the theme whenever a new version releases
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
8a172db3f4
requested review from sauceyred 2025-07-16 03:34:54 +00:00
twig added 1 commit 2025-07-16 03:36:16 +00:00
fix: remove bad "caching" behaviour
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
73606b6bc3
twig added 1 commit 2025-07-16 03:38:01 +00:00
fix: ensure both href theme updates result in the same url
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
2ce09e7c7a
sauceyred commented 2025-07-16 16:41:25 +00:00
Owner
Copy link

Have you tested this?

Have you tested this?
twig commented 2025-07-17 02:44:15 +00:00
Author
Owner
Copy link

@sauceyred wrote in #43 (comment):

Have you tested this?

i mean it works locally

@sauceyred wrote in https://git.gorb.app/gorb/frontend/pulls/43#issuecomment-687: > Have you tested this? i mean it works locally
sauceyred approved these changes 2025-07-18 01:42:29 +00:00
twig added 1 commit 2025-07-18 05:32:00 +00:00
Merge remote-tracking branch 'origin/main' into force-css-regrab
All checks were successful
ci/woodpecker/push/build-and-publish Pipeline was successful
Details
ci/woodpecker/pr/build-and-publish Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-and-publish Pipeline was successful
Details
3953a754bd
twig merged commit 4d5cd86ec3 into main 2025-07-18 05:32:12 +00:00
twig deleted branch force-css-regrab 2025-07-18 05:32:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sauceyred
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
WIP

Not yet ready

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gorb/frontend#43
No description provided.
Delete branch "force-css-regrab"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?