From d5b766929140ff90627f00752a6c6121ef838def Mon Sep 17 00:00:00 2001 From: JustTemmie <47639983+JustTemmie@users.noreply.github.com> Date: Wed, 16 Jul 2025 11:25:36 +0200 Subject: [PATCH 1/2] fix: allow optional argument instead of defaulting to undefined --- utils/getDisplayName.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/getDisplayName.ts b/utils/getDisplayName.ts index 52474f3..e712555 100644 --- a/utils/getDisplayName.ts +++ b/utils/getDisplayName.ts @@ -1,6 +1,6 @@ import type { GuildMemberResponse, UserResponse } from "~/types/interfaces"; -export function getDisplayName(user: UserResponse, member: GuildMemberResponse | undefined = undefined): string { +export function getDisplayName(user: UserResponse, member?: GuildMemberResponse): string { if (member?.nickname) return member.nickname if (user.display_name) return user.display_name return user.username From 0c4d42f3c1307081e51d0b5c2d7068dc2f62d559 Mon Sep 17 00:00:00 2001 From: JustTemmie <47639983+JustTemmie@users.noreply.github.com> Date: Wed, 16 Jul 2025 11:27:35 +0200 Subject: [PATCH 2/2] style: remove function names from implicit util functions --- utils/getDisplayName.ts | 2 +- utils/hashing.ts | 2 +- utils/sortMembers.ts | 2 +- utils/sortUsers.ts | 2 +- utils/validation.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/utils/getDisplayName.ts b/utils/getDisplayName.ts index e712555..015edbc 100644 --- a/utils/getDisplayName.ts +++ b/utils/getDisplayName.ts @@ -1,6 +1,6 @@ import type { GuildMemberResponse, UserResponse } from "~/types/interfaces"; -export function getDisplayName(user: UserResponse, member?: GuildMemberResponse): string { +export default (user: UserResponse, member?: GuildMemberResponse): string => { if (member?.nickname) return member.nickname if (user.display_name) return user.display_name return user.username diff --git a/utils/hashing.ts b/utils/hashing.ts index 847a9dc..d87af14 100644 --- a/utils/hashing.ts +++ b/utils/hashing.ts @@ -1,4 +1,4 @@ -export async function hashPassword(password: string) { +export default async (password: string) => { const encodedPass = new TextEncoder().encode(password); const hashBuffer = await crypto.subtle.digest("SHA-384", encodedPass); const hashArray = Array.from(new Uint8Array(hashBuffer)); diff --git a/utils/sortMembers.ts b/utils/sortMembers.ts index fba862c..87a1a2a 100644 --- a/utils/sortMembers.ts +++ b/utils/sortMembers.ts @@ -1,6 +1,6 @@ import type { GuildMemberResponse } from "~/types/interfaces"; -export default function sortMembers(members: GuildMemberResponse[]): GuildMemberResponse[] { +export default (members: GuildMemberResponse[]): GuildMemberResponse[] => { return members.sort((a, b) => { return getDisplayName(a.user, a).localeCompare(getDisplayName(b.user, b)) }) diff --git a/utils/sortUsers.ts b/utils/sortUsers.ts index 8be8613..8708366 100644 --- a/utils/sortUsers.ts +++ b/utils/sortUsers.ts @@ -1,6 +1,6 @@ import type { UserResponse } from "~/types/interfaces"; -export default function sortUsers(users: UserResponse[]): UserResponse[] { +export default (users: UserResponse[]): UserResponse[] => { return users.sort((a, b) => { return getDisplayName(a).localeCompare(getDisplayName(b)) }) diff --git a/utils/validation.ts b/utils/validation.ts index 48e13ef..9066df5 100644 --- a/utils/validation.ts +++ b/utils/validation.ts @@ -1,3 +1,3 @@ -export function validateUsername(username: string) { +export default (username: string) => { return /^[\w.-]+$/.test(username); } \ No newline at end of file