gorb/backend
5
0
Fork 1
Code Issues 14 Pull requests Projects Releases Packages 1 Wiki Activity Actions

wip/kick #36

Merged
radical merged 9 commits from wip/kick into main 2025-07-22 16:56:37 +00:00
Conversation 2 Commits 9 Files changed 4 +6 -4
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ea33230e58 - Show all commits

10
src/api/v1/member/uuid/mod.rs
View file

@ -1,4 +1,4 @@
//! `/api/v1/member/{uuid}` Member specific endpoints
//! `/api/v1/members/{uuid}` Member specific endpoints
use std::sync::Arc;
@ -41,15 +41,17 @@ pub async fn delete(
) -> Result<impl IntoResponse, Error> {
radical marked this conversation as resolved Outdated
radical commented 2025-07-22 15:50:23 +00:00
Outdated
Copy link

instead of calling app_state.pool.get().await? on multiple functions you should define it and use the same one multiple times

let mut conn = app_state.pool.get().await?;

let me = Me::get(&mut conn, uuid).await?;

let member = Member::fetch_one_with_member(&app_state, &me, member_uuid).await?;

let deleter = Member::check_membership(&mut conn, uuid, member.guild_uuid).await?;
    
deleter.check_permission(&app_state, Permissions::ManageMember).await?;

member.delete(&mut conn).await?;
instead of calling `app_state.pool.get().await?` on multiple functions you should define it and use the same one multiple times ```rs let mut conn = app_state.pool.get().await?; let me = Me::get(&mut conn, uuid).await?; let member = Member::fetch_one_with_member(&app_state, &me, member_uuid).await?; let deleter = Member::check_membership(&mut conn, uuid, member.guild_uuid).await?; deleter.check_permission(&app_state, Permissions::ManageMember).await?; member.delete(&mut conn).await?; ```
global_checks(&app_state, uuid).await?;
let me = Me::get(&mut app_state.pool.get().await?, uuid).await?;
let mut conn = app_state.pool.get().await?;
let me = Me::get(&mut conn, uuid).await?;
let member = Member::fetch_one_with_member(&app_state, &me, member_uuid).await?;
let deleter = Member::check_membership(&mut app_state.pool.get().await?, uuid, member.guild_uuid).await?;
let deleter = Member::check_membership(&mut conn, uuid, member.guild_uuid).await?;
deleter.check_permission(&app_state, Permissions::ManageMember).await?;
member.delete(&mut app_state.pool.get().await?).await?;
member.delete(&mut conn).await?;
Ok(StatusCode::OK)
}