Compare commits

...

4 commits

Author SHA1 Message Date
BAaboe
6dd8ddb0df fix: members in router_with_auth
Some checks failed
ci/woodpecker/push/build-and-publish Pipeline was successful
ci/woodpecker/pr/build-and-publish Pipeline failed
2025-07-22 18:27:36 +02:00
BAaboe
31596c6bfe fix: memebrs not member as endpoint 2025-07-22 18:26:04 +02:00
BAaboe
ea33230e58 fix: reduced numder of function calls to get conn 2025-07-22 18:10:37 +02:00
BAaboe
0468d1adca fix: Unecessary merge of routers 2025-07-22 18:05:19 +02:00
3 changed files with 11 additions and 13 deletions

View file

@ -10,12 +10,8 @@ use crate::{AppState, api::v1::auth::CurrentUser};
mod uuid;
pub fn router(app_state: Arc<AppState>) -> Router<Arc<AppState>> {
let router_with_auth = Router::new()
pub fn router() -> Router<Arc<AppState>> {
Router::new()
.route("/{uuid}", get(uuid::get))
.route("/{uuid}", delete(uuid::delete))
.layer(from_fn_with_state(app_state, CurrentUser::check_auth_layer));
Router::new()
.merge(router_with_auth)
}

View file

@ -1,4 +1,4 @@
//! `/api/v1/member/{uuid}` Member specific endpoints
//! `/api/v1/members/{uuid}` Member specific endpoints
use std::sync::Arc;
@ -41,15 +41,17 @@ pub async fn delete(
) -> Result<impl IntoResponse, Error> {
global_checks(&app_state, uuid).await?;
let me = Me::get(&mut app_state.pool.get().await?, uuid).await?;
let mut conn = app_state.pool.get().await?;
let me = Me::get(&mut conn, uuid).await?;
let member = Member::fetch_one_with_member(&app_state, &me, member_uuid).await?;
let deleter = Member::check_membership(&mut app_state.pool.get().await?, uuid, member.guild_uuid).await?;
let deleter = Member::check_membership(&mut conn, uuid, member.guild_uuid).await?;
deleter.check_permission(&app_state, Permissions::ManageMember).await?;
member.delete(&mut app_state.pool.get().await?).await?;
member.delete(&mut conn).await?;
Ok(StatusCode::OK)
}

View file

@ -13,13 +13,14 @@ mod invites;
mod me;
mod stats;
mod users;
mod member;
mod members;
pub fn router(app_state: Arc<AppState>) -> Router<Arc<AppState>> {
let router_with_auth = Router::new()
.nest("/users", users::router())
.nest("/guilds", guilds::router())
.nest("/invites", invites::router())
.nest("/members", members::router())
.nest("/me", me::router())
.layer(from_fn_with_state(
app_state.clone(),
@ -29,7 +30,6 @@ pub fn router(app_state: Arc<AppState>) -> Router<Arc<AppState>> {
Router::new()
.route("/stats", get(stats::res))
.nest("/auth", auth::router(app_state.clone()))
.nest("/channels", channels::router(app_state.clone()))
.nest("/member", member::router(app_state))
.nest("/channels", channels::router(app_state))
.merge(router_with_auth)
}