Compare commits

..

4 commits

Author SHA1 Message Date
bda9f85b86 feat: query user creation instead of using .execute on pool
This should increase security of the operation a ton, need to test if an escape is still possible
2025-04-30 11:12:01 +00:00
799a1ff49e fix: use raw_sql instead of .execute 2025-04-30 11:11:19 +00:00
0f1824b366 fix: query actual number of accounts 2025-04-30 11:10:25 +00:00
1f897deb33 chore: add config.toml to gitignore 2025-04-30 11:10:02 +00:00
4 changed files with 60 additions and 47 deletions

1
.gitignore vendored
View file

@ -20,3 +20,4 @@ Cargo.lock
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/
/config.toml

View file

@ -93,17 +93,14 @@ pub async fn res(mut payload: web::Payload, data: web::Data<Data>) -> Result<Htt
))
}
Ok(match data.pool.execute(
&*format!(
// FIXME: This can never be put into prod, it works for testing
"INSERT INTO users VALUES ( '{}', '{}', NULL, '{}', '{}', '0' )",
uuid,
account_information.identifier,
// TODO: Check security of this implementation
Ok(match sqlx::query(&format!("INSERT INTO users VALUES ( '{}', $1, NULL, $2, $3, false )", uuid))
.bind(account_information.identifier)
// FIXME: Password has no security currently, either from a client or server perspective
account_information.password,
account_information.email,
)
).await {
.bind(account_information.password)
.bind(account_information.email)
.execute(&data.pool)
.await {
Ok(_out) => {
HttpResponse::Ok().json(
Response {
@ -126,9 +123,10 @@ pub async fn res(mut payload: web::Payload, data: web::Data<Data>) -> Result<Htt
email_available: false,
..Default::default()
}),
_ => HttpResponse::Forbidden().json(ResponseError {
..Default::default()
})
_ => {
eprintln!("{}", err_msg);
HttpResponse::InternalServerError().finish()
}
}
},
})

View file

@ -17,9 +17,16 @@ struct Response {
#[get("/stats")]
pub async fn res(data: web::Data<Data>) -> impl Responder {
let accounts;
if let Ok(users) = sqlx::query("SELECT uuid FROM users").fetch_all(&data.pool).await {
accounts = users.len();
} else {
return HttpResponse::InternalServerError().finish()
}
let response = Response {
// TODO: Get number of accounts from db
accounts: 0,
accounts,
uptime: SystemTime::now()
.duration_since(data.start_time)
.expect("Seriously why dont you have time??")

View file

@ -26,15 +26,22 @@ async fn main() -> Result<(), Error> {
TODO: Figure out if a table should be used here and if not then what.
Also figure out if these should be different types from what they currently are and if we should add more "constraints"
*/
pool.execute(r#"CREATE TABLE IF NOT EXISTS users (
uuid uuid UNIQUE NOT NULL,
sqlx::raw_sql(r#"
CREATE TABLE IF NOT EXISTS users (
uuid uuid PRIMARY KEY UNIQUE NOT NULL,
username varchar(32) UNIQUE NOT NULL,
display_name varchar(64),
password varchar(512) NOT NULL,
email varchar(100) UNIQUE NOT NULL,
email_verified integer NOT NULL DEFAULT '0',
PRIMARY KEY (uuid)
)"#).await?;
email_verified boolean NOT NULL DEFAULT FALSE
);
CREATE TABLE IF NOT EXISTS instance_permissions (
uuid uuid REFERENCES users(uuid),
administrator boolean NOT NULL DEFAULT FALSE
)
"#)
.execute(&pool)
.await?;
let data = Data {
pool,