feat: migrate to diesel and new error type in auth

src/api/v1/auth/revoke.rs

@@ -1,10 +1,10 @@
-use actix_web::{Error, HttpRequest, HttpResponse, post, web};
+use actix_web::{HttpRequest, HttpResponse, post, web};
 use argon2::{PasswordHash, PasswordVerifier};
-use futures::future;
-use log::error;
-use serde::{Deserialize, Serialize};
+use diesel::{delete, ExpressionMethods, QueryDsl};
+use diesel_async::RunQueryDsl;
+use serde::Deserialize;
 
-use crate::{Data, api::v1::auth::check_access_token, utils::get_auth_header};
+use crate::{api::v1::auth::check_access_token, error::Error, schema::users::dsl as udsl, schema::refresh_tokens::{self, dsl as rdsl}, utils::get_auth_header, Data};
 
 #[derive(Deserialize)]
 struct RevokeRequest {
@@ -12,17 +12,6 @@ struct RevokeRequest {
     device_name: String,
 }
 
-#[derive(Serialize)]
-struct Response {
-    deleted: bool,
-}
-
-impl Response {
-    fn new(deleted: bool) -> Self {
-        Self { deleted }
-    }
-}
-
 // TODO: Should maybe be a delete request?
 #[post("/revoke")]
 pub async fn res(
@@ -32,85 +21,33 @@ pub async fn res(
 ) -> Result<HttpResponse, Error> {
     let headers = req.headers();
 
-    let auth_header = get_auth_header(headers);
+    let auth_header = get_auth_header(headers)?;
 
-    if let Err(error) = auth_header {
-        return Ok(error);
-    }
+    let mut conn = data.pool.get().await?;
 
-    let authorized = check_access_token(auth_header.unwrap(), &data.pool).await;
+    let uuid = check_access_token(auth_header, &mut conn).await?;
 
-    if let Err(error) = authorized {
-        return Ok(error);
-    }
+    let database_password: String = udsl::users
+        .filter(udsl::uuid.eq(uuid))
+        .select(udsl::password)
+        .get_result(&mut conn)
+        .await?;
 
-    let uuid = authorized.unwrap();
-
-    let database_password_raw = sqlx::query_scalar(&format!(
-        "SELECT password FROM users WHERE uuid = '{}'",
-        uuid
-    ))
-    .fetch_one(&data.pool)
-    .await;
-
-    if let Err(error) = database_password_raw {
-        error!("{}", error);
-        return Ok(HttpResponse::InternalServerError().json(Response::new(false)));
-    }
-
-    let database_password: String = database_password_raw.unwrap();
-
-    let hashed_password_raw = PasswordHash::new(&database_password);
-
-    if let Err(error) = hashed_password_raw {
-        error!("{}", error);
-        return Ok(HttpResponse::InternalServerError().json(Response::new(false)));
-    }
-
-    let hashed_password = hashed_password_raw.unwrap();
+    let hashed_password = PasswordHash::new(&database_password).map_err(|e| Error::PasswordHashError(e.to_string()))?;
 
     if data
         .argon2
         .verify_password(revoke_request.password.as_bytes(), &hashed_password)
         .is_err()
     {
-        return Ok(HttpResponse::Unauthorized().finish());
+        return Err(Error::Unauthorized("Wrong username or password".to_string()));
     }
 
-    let tokens_raw = sqlx::query_scalar(&format!(
-        "SELECT token FROM refresh_tokens WHERE uuid = '{}' AND device_name = $1",
-        uuid
-    ))
-    .bind(&revoke_request.device_name)
-    .fetch_all(&data.pool)
-    .await;
+    delete(refresh_tokens::table)
+        .filter(rdsl::uuid.eq(uuid))
+        .filter(rdsl::device_name.eq(&revoke_request.device_name))
+        .execute(&mut conn)
+        .await?;
 
-    if tokens_raw.is_err() {
-        error!("{:?}", tokens_raw);
-        return Ok(HttpResponse::InternalServerError().json(Response::new(false)));
-    }
-
-    let tokens: Vec<String> = tokens_raw.unwrap();
-
-    let mut refresh_tokens_delete = vec![];
-
-    for token in tokens {
-        refresh_tokens_delete.push(
-            sqlx::query("DELETE FROM refresh_tokens WHERE token = $1")
-                .bind(token.clone())
-                .execute(&data.pool),
-        );
-    }
-
-    let results = future::join_all(refresh_tokens_delete).await;
-
-    let errors: Vec<&Result<sqlx::postgres::PgQueryResult, sqlx::Error>> =
-        results.iter().filter(|r| r.is_err()).collect();
-
-    if !errors.is_empty() {
-        error!("{:?}", errors);
-        return Ok(HttpResponse::InternalServerError().finish());
-    }
-
-    Ok(HttpResponse::Ok().json(Response::new(true)))
+    Ok(HttpResponse::Ok().finish())
 }